up the width of the entry a tad.

Thu Mar 11 01:08:25 2004  Jonathan Blandford  <jrb@gnome.org>

        * gtk/gtkfilechooserdefault.c (location_entry_create): up the
        width of the entry a tad.

        * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_init): use
        gtk_entry_completion_selection_changed.  Also, unref the
        completion as we were leaking a reference to it.

diff --git a/ChangeLog b/ChangeLog
index b228ceff47c5f17d222359a98f4a6713c76d7a87..8ffaaf0515540389f3ccaacacb5d10dbe553664f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+Thu Mar 11 01:08:25 2004  Jonathan Blandford  <jrb@gnome.org>
+
+       * gtk/gtkfilechooserdefault.c (location_entry_create): up the
+       width of the entry a tad.
+
+       * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_init): use
+       gtk_entry_completion_selection_changed.  Also, unref the
+       completion as we were leaking a reference to it.
+
 2004-03-10  Federico Mena Quintero  <federico@ximian.com>
 
        * gtk/gtkstyle.c (draw_dot): Remove spurious semicolon.  Thanks to

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index b228ceff47c5f17d222359a98f4a6713c76d7a87..8ffaaf0515540389f3ccaacacb5d10dbe553664f 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,12 @@
+Thu Mar 11 01:08:25 2004  Jonathan Blandford  <jrb@gnome.org>
+
+       * gtk/gtkfilechooserdefault.c (location_entry_create): up the
+       width of the entry a tad.
+
+       * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_init): use
+       gtk_entry_completion_selection_changed.  Also, unref the
+       completion as we were leaking a reference to it.
+
 2004-03-10  Federico Mena Quintero  <federico@ximian.com>
 
        * gtk/gtkstyle.c (draw_dot): Remove spurious semicolon.  Thanks to

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index b228ceff47c5f17d222359a98f4a6713c76d7a87..8ffaaf0515540389f3ccaacacb5d10dbe553664f 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,12 @@
+Thu Mar 11 01:08:25 2004  Jonathan Blandford  <jrb@gnome.org>
+
+       * gtk/gtkfilechooserdefault.c (location_entry_create): up the
+       width of the entry a tad.
+
+       * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_init): use
+       gtk_entry_completion_selection_changed.  Also, unref the
+       completion as we were leaking a reference to it.
+
 2004-03-10  Federico Mena Quintero  <federico@ximian.com>
 
        * gtk/gtkstyle.c (draw_dot): Remove spurious semicolon.  Thanks to

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index b228ceff47c5f17d222359a98f4a6713c76d7a87..8ffaaf0515540389f3ccaacacb5d10dbe553664f 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,12 @@
+Thu Mar 11 01:08:25 2004  Jonathan Blandford  <jrb@gnome.org>
+
+       * gtk/gtkfilechooserdefault.c (location_entry_create): up the
+       width of the entry a tad.
+
+       * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_init): use
+       gtk_entry_completion_selection_changed.  Also, unref the
+       completion as we were leaking a reference to it.
+
 2004-03-10  Federico Mena Quintero  <federico@ximian.com>
 
        * gtk/gtkstyle.c (draw_dot): Remove spurious semicolon.  Thanks to

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index b228ceff47c5f17d222359a98f4a6713c76d7a87..8ffaaf0515540389f3ccaacacb5d10dbe553664f 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,12 @@
+Thu Mar 11 01:08:25 2004  Jonathan Blandford  <jrb@gnome.org>
+
+       * gtk/gtkfilechooserdefault.c (location_entry_create): up the
+       width of the entry a tad.
+
+       * gtk/gtkfilechooserentry.c (gtk_file_chooser_entry_init): use
+       gtk_entry_completion_selection_changed.  Also, unref the
+       completion as we were leaking a reference to it.
+
 2004-03-10  Federico Mena Quintero  <federico@ximian.com>
 
        * gtk/gtkstyle.c (draw_dot): Remove spurious semicolon.  Thanks to

diff --git a/gtk/gtkfilechooserdefault.c b/gtk/gtkfilechooserdefault.c
index 5f0ae23913e9da7405bc89887f0e8a1c5a1cb1e3..6e087ca5e252066758cb9837705ef8371bbff8ad 100644 (file)
--- a/gtk/gtkfilechooserdefault.c
+++ b/gtk/gtkfilechooserdefault.c
@@ -4206,7 +4206,7 @@ location_entry_create (GtkFileChooserDefault *impl)
 
   entry = _gtk_file_chooser_entry_new ();
   /* Pick a good width for the entry */
-  gtk_entry_set_width_chars (GTK_ENTRY (entry), 25);
+  gtk_entry_set_width_chars (GTK_ENTRY (entry), 30);
   gtk_entry_set_activates_default (GTK_ENTRY (entry), TRUE);
   _gtk_file_chooser_entry_set_file_system (GTK_FILE_CHOOSER_ENTRY (entry), impl->file_system);
   _gtk_file_chooser_entry_set_base_folder (GTK_FILE_CHOOSER_ENTRY (entry), impl->current_folder);

diff --git a/gtk/gtkfilechooserentry.c b/gtk/gtkfilechooserentry.c
index 72df4a5043e7e2d1afcd21f929f22c6ba6a4e44f..6235e0d82bb5bca4193d4ae20f0ab361f73a7ab0 100644 (file)
--- a/gtk/gtkfilechooserentry.c
+++ b/gtk/gtkfilechooserentry.c
@@ -153,12 +153,10 @@ gtk_file_chooser_entry_init (GtkFileChooserEntry *chooser_entry)
                                       completion_match_func,
                                       chooser_entry,
                                       NULL);
-
-  renderer = gtk_cell_renderer_text_new ();
-  gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (comp), renderer, TRUE);
-  gtk_cell_layout_add_attribute (GTK_CELL_LAYOUT (comp), renderer, "text", 0);
+  gtk_entry_completion_set_text_column (comp, 0);
 
   gtk_entry_set_completion (GTK_ENTRY (chooser_entry), comp);
+  g_object_unref (comp);
 
   g_signal_connect (chooser_entry, "notify::cursor-position",
                    G_CALLBACK (clear_completion_callback), NULL);